Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ModalDialog available in package API #960

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Conversation

lyzadanger
Copy link
Contributor

@lyzadanger lyzadanger commented Apr 14, 2023

Depends on #959

This PR (finally) exports ModalDialog from the package. It also deprecates Modal.

Fixes #77

@lyzadanger lyzadanger requested a review from acelaya April 14, 2023 18:18
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #960 (2de15ef) into main (0db8571) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #960   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines          911       911           
  Branches       324       324           
=========================================
  Hits           911       911           
Impacted Files Coverage Δ
src/components/feedback/Modal.tsx 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@acelaya acelaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@lyzadanger lyzadanger force-pushed the fix-modal-navigation branch from 13ca1d8 to 98a8e0c Compare April 17, 2023 12:14
Base automatically changed from fix-modal-navigation to main April 17, 2023 12:16
@lyzadanger lyzadanger force-pushed the export-modal-dialog branch from 79f2dbe to 2de15ef Compare April 17, 2023 12:17
@lyzadanger lyzadanger merged commit ea7ebf6 into main Apr 17, 2023
@lyzadanger lyzadanger deleted the export-modal-dialog branch April 17, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement accessible dialogs
2 participants